easyeffects icon indicating copy to clipboard operation
easyeffects copied to clipboard

Crash on import impulse in convolver

Open timsofteng opened this issue 3 years ago • 33 comments

EasyEffects Version

6.2.2

What package are you using?

Other (specify below)

Distribution

Void linux

Describe the bug

When I click Impulses > Import Impulse Easyeffects just closes.

Expected Behavior

Should open modal window to change impulse.

Debug Log

Debug Log
Gdk-Message: 17:43:42.539: Lost connection to Wayland compositor.

Additional Information

It worked before some updates.

timsofteng avatar Feb 01 '22 15:02 timsofteng

Works on 6.1.0

timsofteng avatar Feb 02 '22 08:02 timsofteng

I could not reproduce the problem on my computer. Which PipeWire version are you using? If it is >= 0.3.44 you will need at least EasyEffects 6.2.2

wwmm avatar Feb 02 '22 13:02 wwmm

You are on 6.2.2. Strange...

wwmm avatar Feb 02 '22 13:02 wwmm

Gdk-Message: 17:43:42.539: Lost connection to Wayland compositor.

Is this the only unusual thing in your logs? I have never seen it here on Arch Linux + Gnome + Wayland. Something may be wrong in your gtk installation.

wwmm avatar Feb 02 '22 13:02 wwmm

Works on 6.1.0

6.1.x releases were still using gtkmm. From 6.2.x onward we started to use gtk4 directly.

wwmm avatar Feb 02 '22 13:02 wwmm

At this moment I have on Arch Linux gtk4 4.6.0. What is the version on Void?

wwmm avatar Feb 02 '22 13:02 wwmm

At this moment I have on Arch Linux gtk4 4.6.0. What is the version on Void?

Same on Void.

timsofteng avatar Feb 02 '22 14:02 timsofteng

Which desktop environment are you using? This may be some kind gtk4 bug.

wwmm avatar Feb 02 '22 14:02 wwmm

Which desktop environment are you using? This may be some kind gtk4 bug.

Sway

timsofteng avatar Feb 02 '22 14:02 timsofteng

Sway

Another users have reported different issues with gtk4 on Sway. But I think you are the first to report a crash on the import file dialog. In any case it is becoming clear that gtk4 and sway developers have to take a look at what is going on.

wwmm avatar Feb 02 '22 14:02 wwmm

#1296 is an example.

wwmm avatar Feb 02 '22 14:02 wwmm

Is there a crash in the Import Preset dialog too or does it happen only in the convolver menu?

wwmm avatar Feb 02 '22 14:02 wwmm

Is there a crash in the Import Preset dialog too or does it happen only in the convolver menu?

It crashes on Import Preset too.

timsofteng avatar Feb 02 '22 15:02 timsofteng

@wwmm Is there a way to import the file without using the UI? Having the same problem on Ubuntu 21.10

OliverGeneser avatar Mar 07 '22 09:03 OliverGeneser

@OliverGeneser take a look at the folder

ls ~/.config/easyeffects/
autoload  input  irs  output  rnnoise

What the dialogs do is copying the files to one of these folders.

wwmm avatar Mar 07 '22 14:03 wwmm

The issue still exists for `6.2.4.

timsofteng avatar Mar 30 '22 18:03 timsofteng

The issue still exists for `6.2.4.

As the issue seems to be related to gtk4 and sway incompatibilities updates on our side probably won't make any difference. Something has to be done on gtk4 or sway.

wwmm avatar Mar 30 '22 20:03 wwmm

Hi everyone, is there any update on this? This is now happening on my Pop!_OS install. I can't remember if it worked before and then stopped working, because I've apparently in the past been able to import 2 presets under the Convolver module. However, when I tried to import new presets this morning by clicking on Import Impulse, the entire computer froze. The dialog to import the modules showed up but I couldn't do anything, not even CTRL + ALT +DEL or any other key combo could unlock the PC. What's strange is that the music in the background kept playing and the OS apparently never detected that the program was stuck. I had to give the PC a hard shutdown in order for it to stop. Again, I don't know if it worked before but it doesn't work anymore now. I'm on EasyEffect 6.2.6 and Linux kernel 5.17.15 on Pop!_OS 22.04 LTS.

proairface avatar Jul 18 '22 20:07 proairface

Hi everyone, is there any update on this?

No. I still do not see any crashes.

The dialog to import the modules showed up but I couldn't do anything, not even CTRL + ALT +DEL or any other key combo could unlock the PC.

This is a different problem related to gtk4 bugs. You are not seeing a crash. In this case it is gtk4 freezing when some actions are done. Like opening Popover menus or dialogs. Based on user reports it seems to be worse on Xorg. But at least in the case of the menus gtk4 has some problems on Wayland too.

The gtk page on gitlab already has an open issue about its popover menu bugs. But I am not sure the dialog problems have already been reported to them. Ideally thee people having these problems should make reports there too. I doubt we can fix them only on our side.

wwmm avatar Jul 18 '22 23:07 wwmm

Good day wwmm, thanks for your quick and detailed response! I understand that this is not something you guys can fix. Therefore I would like to apologize for posting my comment here. Can I therefore suggest to close this/these threads since I was under the impression that this issue was still on the 'to-do' list for the EasyEffects devs. I´d like to think that that also benefits the devs in order to reduce the huge amount of Issue tickets open here on Github so they can focus on the actual tickets that have legitimate issues with EasyEffects in them. Do you agree? Could you link me the Gitlab page where the popover menu bug is mentioned? I can´t seem to find it. I will make sure to mention the aforementioned behavior there and I hope it will be fixed soon.

proairface avatar Jul 21 '22 17:07 proairface

Good day wwmm, thanks for your quick and detailed response! I understand that this is not something you guys can fix. Therefore I would like to apologize for posting my comment here.

No problems :-)

Can I therefore suggest to close this/these threads since I was under the impression that this issue was still on the 'to-do' list for the EasyEffects devs.

If I understood correctly this issue is a little different from the others because a crash was reported and not the typical gtk4 freeze some users are facing in some situations. So it makes some sense to keep it open. About the others we are keeping just #1182 and #1179 open and closing anything that seems to be a duplicate. As people will keep opening issues here about the gtk freeze while the bugs are not fixed by the GTK developers we won't gain much by closing these two. It is better to keep them open and closing the new ones.

I´d like to think that that also benefits the devs in order to reduce the huge amount of Issue tickets open here on Github so they can focus on the actual tickets that have legitimate issues with EasyEffects in them. Do you agree?

It would be nice. No doubt. But like I said people will keep opening issues about this here anyway.

Could you link me the Gitlab page where the popover menu bug is mentioned? I can´t seem to find it. I will make sure to mention the aforementioned behavior there and I hope it will be fixed soon.

Sure. The one about the popover menus can be found here https://gitlab.gnome.org/GNOME/gtk/-/issues/3502. You will see that it has been a while since a comment was done there by the GTK developers. And when I mentioned that some people are having similar problems with dialog windows one of the main developers suggested we did not mix issues... As I do not have problems with dialog windows (I use wayland) it would be better if someone else opened an issue about them.

wwmm avatar Jul 21 '22 19:07 wwmm

This is one I have opened myself https://gitlab.gnome.org/GNOME/gtk/-/issues/4369. It is the only issue I see on Wayland. The others happen only for people on Xorg as far as I know.

wwmm avatar Jul 21 '22 19:07 wwmm

@wwmm Thanks for your quick and detailed reply. I just read the rather painful comment by one of the GTK devs on the mentioned URL (https://gitlab.gnome.org/GNOME/gtk/-/issues/4369). I myself am not a developer and reading a comment like that does not inspire any hope for me to create a new ticket. I fear that they will not take me seriously and I sadly don´t have the technical know-how to describe (on a technical/programming level) what the issue is. I will accept the fact that EasyEffects won't work in some areas and we will have to see when this gets fixed. I can only say: thank you wwmm for replying in all of these issues on your Github and let's hope that the GTK devs recognize this issue soon.

proairface avatar Jul 24 '22 20:07 proairface

facing the same issue with sway on arch linux

hossamdash avatar Dec 06 '22 14:12 hossamdash

I am not the OP but I resolved this on my system (Arch Linux + sway) by installing xdg-desktop-portal-wlr and setting XDG_CURRENT_DESKTOP=sway in /etc/environment.

Now the program doesn't crash and I am able to select and import a file.

lennie420 avatar Jan 04 '23 14:01 lennie420

I am not the OP but I resolved this on my system (Arch Linux + sway) by installing xdg-desktop-portal-wlr and setting XDG_CURRENT_DESKTOP=sway in /etc/environment.

Interesting. In our code we call gtk functions that are supposed to show native dialogs for each desktop. But I was not expecting it to crash when the requirements were not installed in the desktop side.

wwmm avatar Jan 05 '23 01:01 wwmm

I am not the OP but I resolved this on my system (Arch Linux + sway) by installing xdg-desktop-portal-wlr and setting XDG_CURRENT_DESKTOP=sway in /etc/environment.

Now the program doesn't crash and I am able to select and import a file.

This doesn't solve the issue for me

https://user-images.githubusercontent.com/61992392/211055984-7c8a79c3-4fce-445d-a7bc-eb71bc776094.mp4

hossamdash avatar Jan 06 '23 16:01 hossamdash

Okay on a new install it doesn't seem that works so I must have had something else installed or configured...

lennie420 avatar Jan 08 '23 18:01 lennie420

Okay on a new install it doesn't seem that works so I must have had something else installed or configured...

It makes sense. Are you still using Sway? Considering that people on GNOME and KDE are not seeing this problem and that at some point things worked for you gtk4 may be needing some kind of package when running on sway that it does not need on other desktops.

wwmm avatar Jan 08 '23 21:01 wwmm

I really can't think of what else I would have installed or what I was doing differently before that it's not working now.

However a somewhat strange workaround is to launch EasyEffects, make the window fullscreen and then I am able to import and load a file... This is without any environmental variables and without xdg-desktop-portal etc installed. It's possible I went through this process beforehand and incorrectly assumed it was the environmental variable or other packages.

Although, it does seems like there is something funky going on because it doesn't seem to load the file properly and I get a message in red "Failed To Load The Impulse File" above the graph. If EasyEffects is closed and opened again the impulse seems to be loaded correctly.

Error messages that were output during testing (EasyEffects loaded from terminal): Gdk-Message: 23:01:28.588: Lost connection to Wayland compositor.

(easyeffects:3875): Gdk-WARNING **: 23:02:46.789: Compositor doesn't support moving popups, relying on remapping

lennie420 avatar Jan 08 '23 23:01 lennie420