wwmayer

Results 133 comments of wwmayer

https://github.com/FreeCAD/FreeCAD/pull/13033

``` from PySide import QtWidgets tree = QtWidgets.QTreeWidget() item = QtWidgets.QTreeWidgetItem() item.setText(0, "Suppressed") font = item.font(0) font.setStrikeOut(True) item.setFont(0, font) tree.addTopLevelItem(item) tree.show() ```

> Do you tell I have to use python to update the PartDesign objects at property change? It's my reply to this question: > do you know if strikethrough text...

In how far is this related to https://github.com/FreeCAD/FreeCAD/issues/5545? Original ticket in Mantis: https://tracker.freecad.org/view.php?id=402 Forum thread: https://forum.freecad.org/viewtopic.php?t=1070

> Click on Redraw Page Python's GIL must be locked before accessing the attributes. So, add this line `Base::PyGILStateLocker lock;` before `if (proxy && proxy->getValue().hasAttr("saveAssemblyAndExplode"))`

No, it only fixed partially the problem. There are still 12 failing tests with this difference of the created inp files: ``` @@ -95 +95 @@ -*NODE FILE, OUTPUT=3d +*NODE...

> Is it still with a clean config? No, I use my standard config. > There was a PR that changed the default from 2d to 3d (for a very...

OK, thanks for the links. Making a feature class directly depending on user parameters is bad practice because it adds mutable global state to this class. This is as bad...

The comments in `src/Mod/MeshPart/App/MeshFlatteningLscmRelax.cpp` shouldn't be removed, the rest is OK.