wwmayer

Results 133 comments of wwmayer

The utility will replace all tabs with spaces and uses 4 spaces for the indentations. So, exactly this what the ticket is about.

Are you sure the macro does what you expect? When I load your test file, select every object of the document and then run the macro I have these issues...

> As far as I can tell App::ExpressionTokenizer().perform() isn't used anywhere. ExpressionTokenizer::perform() is used in ExpressionCompleter::slotUpdate. In the past its code was bundled with ExpressionCompleter and has been refactored with...

`if (getGuiDocument()->isModified())` getGuiDocument() can return null

getAppDocument() is a convenience method to get the App document of a Gui document. If getGuiDoucment() returns null then getAppDocument() will do so, too. It's best to write the method...

> Has QString QString::fromStdString(const std::string &str) been considered buggy? In the past (Qt4) if a std::string contained a utf-8 encoded string then using fromStdString() caused problems because it internally used...

> I also noticed that there exist Base::Tools function: This function once was needed as convenience for the above explained reason. Now it's obsolete and can be removed.

https://doc.qt.io/qt-6/qwidget.html#windowTitle-prop https://doc.qt.io/qt-6/qwidget.html#windowModified-prop