wwmayer

This issue is not related to #13915. The crash occurs inside afterHandlerModeChanged() at line 463 because of a heap-use-after-free error. The sketchHandler will be destroyed in ViewProviderSketch::deactivateHandler() but ViewProviderSketch::mouseButtonPressed() it's...

The issue is a bit more complex. The DrawSketchHandlerSymmetry purges itself after the click (by calling ViewProviderSketch::deactivateHandler()). So, it will be destroyed inside a member function but then still accesses...

The logic of the sketch handlers is somewhat convoluted because the view provider has a pointer to it and the handler has a pointer to the sketch. Then, the handler...

For some reason this PR makes the Pad test to fail. Have you checked why this is the case?

https://github.com/FreeCAD/FreeCAD/pull/13675

Many source and header files show the copyright of other people. Is the code copy & pasted? Also all new files should use the updated copyright text.

https://forum.freecad.org/viewtopic.php?p=687919#p687919

In his branch RT has a setting to check or ignore for multiple solids after each operation. IMO that's the easiest way to handle both cases.

I don't know if this is officially documented but I vote to apply the same indentation rules as for our C++ or Python code: 4 spaces, no tabs

I haven't found a utility to do the XML formatting as we want it. There is xmllint but it uses only two spaces. So, I have written our own utility:...