primrose icon indicating copy to clipboard operation
primrose copied to clipboard

Documentation error in CsvReader for header parameter

Open rjsbhatia opened this issue 6 years ago • 0 comments

In the documentation for CsvReader it says we can pass the header parameter. The example shows a possible value of None.

Example: "csv_reader": {
"class": "CsvReader",
"filename": "data/mydata.csv",
"kwargs": {
"header": None,
"sep": ":"
}
} \

Json(and yaml) have issues with None. If you pass Null instead of None the reader works.

https://github.com/WW-Digital/ww-primrose/blob/b8b0eb9befc78d42c48cd0573a1dc6d1dfaef71d/primrose/readers/csv_reader.py#L42


As an aside, I was trying to write this data to BigQuery and if there is no header the Bqwriter fails.

rjsbhatia avatar Feb 27 '20 15:02 rjsbhatia