scoped_search icon indicating copy to clipboard operation
scoped_search copied to clipboard

Deprecated functionality for Ruby 2.7

Open panbanda opened this issue 3 years ago • 7 comments

Hey there.

/app/vendor/cache/ruby/2.7.0/bundler/gems/scoped_search-b692e7335357/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/app/vendor/cache/ruby/2.7.0/bundler/gems/scoped_search-b692e7335357/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

Seeing this error a lot with the separation of positional and keyword arguments.

https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/

I am using the v4.1.9 branch.

panbanda avatar Jul 13 '21 06:07 panbanda

This should most likely be fixed by https://github.com/wvanbergen/scoped_search/pull/204 , could you check with latest master?

adamruzicka avatar Jul 13 '21 09:07 adamruzicka

Yep, seems to be fixed. @adamruzicka

BTW, saw that there are some tags being made but no releases. Is there a reason for that?

panbanda avatar Jul 13 '21 10:07 panbanda

I'm not sure I follow. The tags are in the repo and corresponding releases are out on rubygems. Or are you talking about some other release?

adamruzicka avatar Jul 13 '21 10:07 adamruzicka

Sorry, spoke too soon. My logs just spat out the same error for master at rev 92939afa16dd

panbanda avatar Jul 13 '21 10:07 panbanda

I'm not sure I follow. The tags are in the repo and corresponding releases are out on rubygems. Or are you talking about some other release?

Ah, yes I was looking at the gh releases. Thought it was all tied together.

panbanda avatar Jul 13 '21 10:07 panbanda

Just FYI, seeing the latest with 4.1.9

/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

panbanda avatar Aug 11 '21 20:08 panbanda

also got

/usr/local/bundle/ruby/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:309: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/usr/local/bundle/ruby/2.7.0/gems/scoped_search-4.1.9/lib/scoped_search/definition.rb:27: warning: The called method `initialize' is defined here

slayer avatar Oct 04 '21 20:10 slayer