SpringAll icon indicating copy to clipboard operation
SpringAll copied to clipboard

Published 20 hours ago • verified publisher icon wuyouzhuguli

Update active_model_serializers 0.9.7 to 0.10.10

Open pravi opened this issue 3 years ago • 4 comments

Changelog https://github.com/rails-api/active_model_serializers/blob/master/CHANGELOG-0-10.md

pravi avatar Sep 21 '20 10:09 pravi

Upgrade guide https://github.com/rails-api/active_model_serializers/blob/v0.10.6/docs/howto/upgrade_from_0_8_to_0_10.md

pravi avatar Sep 21 '20 17:09 pravi

some pointers https://github.com/rails-api/active_model_serializers/issues/2028

pravi avatar Sep 22 '20 05:09 pravi

Could you please run tests and code style checks on your machine before pushing? Having the code review bot spam the same comments over and over again frequently ends in the bot being temporarily disabled, and that's quite annoying to deal with. :)

denschub avatar Sep 22 '20 08:09 denschub

Not sure what the benefit of upgrading here is while not porting the code but using a compat layer. A proper port is welcome.

jhass avatar Apr 11 '21 12:04 jhass