SpringAll icon indicating copy to clipboard operation
SpringAll copied to clipboard

Suggestion to switch from rails-assets-jquery.ui to jquery-ui-rails

Open pravi opened this issue 3 years ago • 4 comments

Would it be a good idea to switch to jquery-ui-rails from rails-assets-jquery.ui to reduce the number of gems we have to cache?

pravi avatar Sep 12 '20 15:09 pravi

I see no good reason? Caching the gem is no work whatsoever, as it really doesn't matter how many gems are stored there. It also makes no difference in terms of reliability, since the setup still depends on our cache.

Can you explain your motivation? :)

denschub avatar Sep 13 '20 11:09 denschub

I think my motivation will not change your mind :) jquery-rails is already packaged in debian so it helps me in maintaining diaspora in debian (I have not been actively following up packaging for a long time, but getting back to it now). But since I'm prepared to do the extra work, I'll manage the extra work.

But just one more argument that could influence you, since rails-assets.org is not getting updates (last time I checked their ci was failing, not sure if they fixed it), jquery-ui-rails would get new updates of jquery-ui.

pravi avatar Sep 14 '20 06:09 pravi

https://rails-assets.org/status shows failures for some assets we use like highlight-js

pravi avatar Sep 14 '20 06:09 pravi

What we should do is to upgrade to Rails 6 and switch to the webpacker based asset pipeline. But that's quite some work.

That said if you got a patch to switch out rails-assets-jquery-ui for jquery-ui-rails, we're not entirely uninterested ;)

jhass avatar Sep 14 '20 07:09 jhass