epy icon indicating copy to clipboard operation
epy copied to clipboard

epy crashed when changing the size of the terminal

Open rekinyz opened this issue 3 years ago • 5 comments

got following error msg:

_curses.error: addwstr() returned ERR

rekinyz avatar Aug 03 '22 15:08 rekinyz

That's pretty strange... Somehow I cannot recreate the issue when resizing.

Can you elaborate step by step to reproduce the error?

wustho avatar Aug 04 '22 00:08 wustho

  1. installed python 3.9.13 with asdf-vm
  2. tested on two different laptops with pure ubuntu and wsl2 respectively.
  3. created a clean python 3.9.13 .venv
  4. installed epy-reader latest version which is (2022.4.18) with poetry
  5. opened up randomly an .epub
  6. tried to resize terminal window
  7. epy crashed
Traceback (most recent call last):
  File "/home/user/.venv/bin/epy", line 8, in <module>
    sys.exit(main())
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3988, in main
    filepath = curses.wrapper(preread, filepath)
  File "/home/user/.asdf/installs/python/3.9.13/lib/python3.9/curses/__init__.py", line 94, in wrapper
    return func(stdscr, *args, **kwds)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3887, in preread
    reading_state_or_ebook = reader.read(reading_state)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3156, in read
    board.write(reading_state.row)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 1715, in write
    self.screen.addstr(n_row, self.x, text_line)
_curses.error: addwstr() returned ERR

rekinyz avatar Aug 06 '22 11:08 rekinyz

Thanks for complete traceback! Will look into that.

Another question, does it work for other epub file?

wustho avatar Aug 06 '22 11:08 wustho

nope, tested on diverse epub files and even with different languages

rekinyz avatar Aug 06 '22 18:08 rekinyz

I also cannot reproduce. In Ubuntu 20.04 with python 3, epy handles resizing terminal beautifully.

Although, in Windows, resizing the terminal garbles the screen and remains garbled when resized back to original size. But I suspect that's a Windows-specific (win-curses) issue.

3N4N avatar Sep 18 '22 06:09 3N4N