epr icon indicating copy to clipboard operation
epr copied to clipboard

epr.py should give visual indication of chapter ending

Open kanliot opened this issue 4 years ago • 3 comments

If I go to the second chapter, then use <UP> (up on keyboard) to get to the first chapter, epr.py shows <-- END --> as an indication that I've changed chapters.

  1. when using <DOWN> to reach the last line of the chapter, <-- END --> should display before epr.py switches to next chapter.

It's very surprising to see a new chapter, when I use <DOWN> to read the next line.


  1. when using <PAGEDOWN> to reach the last line of the chapter, I'm often surprised that I have lost my reading position, since an unknown number of lines has scrolled past. I don't know if I've read half the page, or 2/3 of the page, or how many lines of the page.

this should be fixed by prefixing each line from the previous page with a * to indicate that only a partial page has been displayed.

         * lines lines
         * lines lines
         * lines lines
         * lines lines
         * lines lines
         * lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines
           lines lines

kanliot avatar Feb 29 '20 12:02 kanliot

Hey there, thanks for feedbacks. Actually the 1st problem you stated above is limitation of this epr, since it process text chapter by chapter allowing epr to run on low memory, at the cost of that 1st problem... To get seamless reading between chapter, it needs to process all text inside epub and process them fast, which is out of my reach since I'm not an actual programmer, just love making script to help my daily life... I tried actually, using multiprocess python packages but, still cannot fully grasp its low level behaviours... Hope somebody will make a pull request regarding this...

2nd problem, I fixed this in https://github.com/wustho/epy but probably forgot to add this patch to epr... So when you hit next page to reach last lines of chapter, you will get a new page containing only that last lines, so we won't lose our reading position, I will add this later to epr, meanwhile you could try https://github.com/wustho/epy

wustho avatar Feb 29 '20 14:02 wustho

thank you for the reply. The lack of indication when reaching the end-of-chapter is a small issue. I hoped you could attach a text at the end of every chapter.

I don't use epr book reader every day, but I do like it to use it, when I'm planning to read a book, but have it open in one of a lot of windows. The program is very well behaved when I want to open multiple chapters in the same book!

Thank you.

On Sat, Feb 29, 2020 at 9:40 AM Benawi Adha [email protected] wrote:

Hey there, thanks for feedbacks. Actually the 1st problem you stated above is limitation of this epr, since it process text chapter by chapter allowing epr to run on low memory, at the cost of that 1st problem... To get seamless reading between chapter, it needs to process all text inside epub and process them fast, which is out of my reach since I'm not an actual programmer, just love making script to help my daily life... I tried actually, using multiprocess python packages but, still cannot fully grasp its low level behaviours...

2nd problem, I fixed this in https://github.com/wustho/epy but probably forgot to add this patch to epr... So when you hit next page to reach last lines of chapter, you will get a new page containing only that last lines, so we won't lose our reading position, I will add this later to epr, meanwhile you could try https://github.com/wustho/epy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wustho/epr/issues/26?email_source=notifications&email_token=AAGL6B4TQWCSM5X3PNKQI6DRFEO4ZA5CNFSM4K6WPQ42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENL3VJQ#issuecomment-592951974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGL6B65HB6SO3EUSQBZ3MLRFEO4ZANCNFSM4K6WPQ4Q .

kanliot avatar Mar 06 '20 19:03 kanliot

@kanliot hey there, been long time. But I added seamless between chapters feature here: https://github.com/wustho/epy

wustho avatar Oct 29 '21 23:10 wustho