sequenceserver
sequenceserver copied to clipboard
Hsp alignment download reformat
FASTA headers of the downloaded HSP alignments now show the hit number and hsp number (in letters) that the user is currently looking at.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Hey @iQuxLE - do these code climate need to be fixed? or are they minor?
And/or are they related to the conflicts that need to be resolved. Are you able to resolve those?
I suppose the issues are more minor. It is just a duplication in two locations and minimizing that won't make it more intuitive and easier to understand.
Are you able to tell Codeclimate to ignore those minor issues (through local in-line ignore/reconfig comments?)
I added filters for the specific functions inside alignment_exporter.js and sidebar.js These filters use the parsing tree to allow codeclimate to prevent a duplication call as these are minor duplications. By that we don't need to change the mass_threshold which would affect all files in sequenceserver.
Given the number of 'Update xyz' kind of commits, it may be desirable to squash-and-merge this PR. That would be git merge --squash on the command line, but also GitHub would offer this option when the remaining file conflict is resolved.
@iQuxLE

I think I have not used the most recent commit that's why there is a conflict cause I don't see the details for this. Let me check the next days.
Yes I think we need a Github action that automatically rebuilds minimised js and css whenever the repo moves
bump
@augeas - could you please pull out the essentials from here?