sequenceserver icon indicating copy to clipboard operation
sequenceserver copied to clipboard

Hsp alignment download reformat

Open iQuxLE opened this issue 3 years ago • 11 comments

FASTA headers of the downloaded HSP alignments now show the hit number and hsp number (in letters) that the user is currently looking at.

iQuxLE avatar Jun 05 '22 16:06 iQuxLE

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 05 '22 16:06 CLAassistant

Hey @iQuxLE - do these code climate need to be fixed? or are they minor?

And/or are they related to the conflicts that need to be resolved. Are you able to resolve those?

yannickwurm avatar Jun 14 '22 16:06 yannickwurm

I suppose the issues are more minor. It is just a duplication in two locations and minimizing that won't make it more intuitive and easier to understand.

iQuxLE avatar Jun 17 '22 10:06 iQuxLE

Are you able to tell Codeclimate to ignore those minor issues (through local in-line ignore/reconfig comments?)

yannickwurm avatar Jun 29 '22 09:06 yannickwurm

I added filters for the specific functions inside alignment_exporter.js and sidebar.js These filters use the parsing tree to allow codeclimate to prevent a duplication call as these are minor duplications. By that we don't need to change the mass_threshold which would affect all files in sequenceserver.

iQuxLE avatar Jul 01 '22 12:07 iQuxLE

Given the number of 'Update xyz' kind of commits, it may be desirable to squash-and-merge this PR. That would be git merge --squash on the command line, but also GitHub would offer this option when the remaining file conflict is resolved.

yeban avatar Jul 11 '22 15:07 yeban

@iQuxLE
Screenshot 2022-07-31 at 22 31 31

yannickwurm avatar Jul 31 '22 20:07 yannickwurm

I think I have not used the most recent commit that's why there is a conflict cause I don't see the details for this. Let me check the next days.

iQuxLE avatar Aug 01 '22 08:08 iQuxLE

Yes I think we need a Github action that automatically rebuilds minimised js and css whenever the repo moves

yannickwurm avatar Aug 01 '22 08:08 yannickwurm

bump

yannickwurm avatar Aug 08 '22 10:08 yannickwurm

@augeas - could you please pull out the essentials from here?

yannickwurm avatar Jul 19 '23 12:07 yannickwurm