vue-credit-card-validation
vue-credit-card-validation copied to clipboard
wuori
Card brand not working with a pasted card number
Can replicate issue on the example page: https://wuori.github.io/vue-credit-card-validation/example/
If the user immediately pastes in their credit card number, the number is formatted and the card type is set on "data-card-brand", but apparently is not passed to cardBrandClass.
Thank you for the detailed report! I'll try to get this fixed within the next week - but feel free to submit a PR in the meantime.
@JamesBurgoon @stefanheimann
I've fixed this by adding a paste event listener on a timeout that just triggers the existing keyup event so none of the core code had to be changed. Perhaps not the "best" fix but as this plugin is already very listener-heavy I don't believe the impacts, at least performance-wise, will be increased much.
Update to v1.0.4 and you should be good to go. Please let me know if you have any issues!
I noticed this has a weird issue where if you paste a number 4420504121201482 the spaces will disappear even though its valid. you have to actually type the full number and then the spaces remain
You also have stray console.logs in your code that make debugging kind of a pain. IMO you should delete those
@9mm I'll try to get a fix in for this. If you need it immediately please feel free to submit a PR and I'll merge. Thanks for the feedback... and sorry about the console.logs :|
No worries! I'm glad I found your library, it is filling a great void. I am super grateful!
@9mm Glad it could help! The project I built it for went nowhere so glad it wasn't all a waste. Also, I believe I allowed it to paste numbers without spaces so that it would work with another package I made for USB magnetic card readers: https://www.npmjs.com/package/vue-cardswipe so I'll see about making that an option to toggle upon instantiation.
Yeah man, it definitely did not go to waste. IMO you have the base for a great project, simply because most card libraries out there are all dead, they are very slim pickins if one is not using stripe. Yours is "most stripe like" and very flexible which is why I chose it!