next-drupal-starterkit icon indicating copy to clipboard operation
next-drupal-starterkit copied to clipboard

NEX-127-1: Switch from pages router to app router

Open vermario opened this issue 1 year ago • 1 comments

Switching to APP router.

This is a big feature, being worked on by @jekku123 mostly for now.

This is a draft PR, so that we can have a place to gather comments and discussions about this big refactoring.

vermario avatar Sep 06 '24 16:09 vermario

@jekku123 hi! I tried testing this a bit, and I think we have an issue in the caching setup: image

Basically the changes saved to the page do not show up unless you are in draft mode.

Either next.js or redis are not getting invalidated, it seems.

If i manually delete the Redis keys, the changes show up

image

vermario avatar Sep 23 '24 05:09 vermario

When going to edit Frontpage I see this preview and when I click that link it renders the Frontpage so is the preview feature creating a new page and returning 404 by default? Anyone else seen this? Actually this seems to be the case

Screenshot 2024-11-14 at 13 59 06

I could not update Frontpage text content and Articles could not be fetched.

Screenshot 2024-11-14 at 14 06 25

Search also does not work.

Could others confirm whether or not this is the case for them as well so we can check as a team in parallel?

Zionknight-crypto avatar Nov 14 '24 12:11 Zionknight-crypto

When going to edit Frontpage I see this preview and when I click that link it renders the Frontpage so is the preview feature creating a new page and returning 404 by default? Anyone else seen this? Actually this seems to be the case Screenshot 2024-11-14 at 13 59 06

I could not update Frontpage text content and Articles could not be fetched. Screenshot 2024-11-14 at 14 06 25

Search also does not work.

Could others confirm whether or not this is the case for them as well so we can check as a team in parallel?

Can't reproduce :-)

Showing Frontpage:

image

Search:

image

Articles:

image

vermario avatar Nov 14 '24 12:11 vermario

@vermario mmm that is odd indeed, I need to re-setup again from start.

Zionknight-crypto avatar Nov 14 '24 12:11 Zionknight-crypto

Something that happens when switching branches is that you might have some old generated code laying around, since this new feature changes the whole structure, and the files generated by the graphl-codegen are now in a new location. so I suggest doing this:

  1. git clean -f <- should get rid of leftover untracked files
  2. ./setup-lando.sh -c will rebuild lando and reinstall drupal and should get you to the initial situation.

vermario avatar Nov 14 '24 12:11 vermario