graphql-go-tools icon indicating copy to clipboard operation
graphql-go-tools copied to clipboard

fix: ignore __typename when setting select reason

Open argoyle opened this issue 1 year ago • 5 comments

Fixes #830

argoyle avatar Jul 09 '24 13:07 argoyle

Can you add test coverage for this?

jensneuse avatar Jul 09 '24 15:07 jensneuse

Of course. Just wanted to get some hint on if this was reasonable or if it will break something else.

argoyle avatar Jul 09 '24 15:07 argoyle

Hi @argoyle

Thanks a lot for your contribution I don't know currently which side effects it could have

Currently, we are doing a rewrite of this functionality, which may fix your issue

I will let you know when we have some results

devsergiy avatar Jul 10 '24 07:07 devsergiy

@devsergiy Should I hold off on creating a test for this then?

argoyle avatar Jul 10 '24 08:07 argoyle

Added a couple of tests anyway

argoyle avatar Jul 10 '24 10:07 argoyle