graphql-go-tools icon indicating copy to clipboard operation
graphql-go-tools copied to clipboard
verified publisher icon wundergraph

feat: add interface-arguments

Open roderm opened this issue 2 years ago • 1 comments

Regarding to this issue here: https://github.com/wundergraph/graphql-go-tools/issues/495

  • extract interface's fields to the Required fields
  • get interfaces's field arguments

roderm avatar Nov 07 '23 11:11 roderm

Hey there, I tried to add some tests and implement this in the main package as well as in v2. In v2 I was not able to run the tests in schema_test.go. I also created and tested this feature/bug in an own repository: https://github.com/roderm/graphql-gateway-examples/tree/master/example-1

  • Most of the code is just copy-paste from ObjectType to InterfaceType. Would you prefer more generic functions and also are generic types okay?
  • Are the tests sufficient or would you like some more tests?
  • Are there any docs that needs to be updated?

roderm avatar Nov 08 '23 08:11 roderm

Hi @roderm are u still interested in this functionality? Once tests are green we could merged into v1 package For the v2 your changes are not required, this code in v2 will be removed soon, as we handle it differently

Sorry for such a big delay, v1 branch is no longer under active support we are fully focused on v2

Please let us know what to do with your branch

Thanks, Wundergraph Team

devsergiy avatar Mar 21 '24 18:03 devsergiy