graphql-go-tools icon indicating copy to clipboard operation
graphql-go-tools copied to clipboard

Remove abstractlogger from ExecutionEngineV2

Open tonquangtu opened this issue 3 years ago • 3 comments
trafficstars

Hi guys, here are some issues I have faced while using abstractlogger.Logger in the graph-go-tools. Please help to assess

  • The logger interface doesn't support log with context.Context. Context normally contains helpful information like request id or trace id which support to trace and debug the issue
  • Each company has its own log solution, abstractlogger seems to stick to zap logger interface that seems not convenient for us to use. The engine just better throws the error outside instead of requiring logger.

Thanks

tonquangtu avatar Jun 28 '22 07:06 tonquangtu

Could you extend abstract logger with your implementation? Or remove it and return meaningful errors instead? I'm not yet sure what direction to go, but open to discussion.

jensneuse avatar Jul 04 '22 10:07 jensneuse

abstractlogger doesn't have a license, so that needs to be addressed for most folks to be able to consume graphql-go-tools today.

https://github.com/jensneuse/abstractlogger/issues/1

schmidtw avatar Jul 12 '22 11:07 schmidtw

abstractlogger doesn't have a license, so that needs to be addressed for most folks to be able to consume graphql-go-tools today.

jensneuse/abstractlogger#1

I'll fix this.

jensneuse avatar Jul 12 '22 11:07 jensneuse