wundergraph
feat: add support for request compression
/claim #602
WIP
Added functions to compress the response and decompress the request.
TODO
- [x] Tests or benchmark included
- [ ] Documentation is changed or added on https://app.gitbook.com/
- [x] PR title must follow conventional-commit-standard
This PR was marked stale due to lack of activity. It will be closed in 14 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@StarpTech with the current implementation We would have to add. Content-Type in response header I tried to add middleware for it but failed to do it. Could you please check the latest changes?
This PR was marked stale due to lack of activity. It will be closed in 14 days.
@StarpTech Thank you for review. all the requested changes is completed.
@StarpTech tests are failing for Authentication. I don't know why this is happening. I did not make any changes to the Authentication module. can please check it.
Sounds great. I think we can merge it this week. I'll do a last test tomorrow.
@StarpTech changes applied. Github action Router CI is falling don't know why. It is not related to my code.
After updating branch.
@Rutik7066 https://github.com/wundergraph/cosmo/pull/723#discussion_r1613153286
@StarpTech we can merge this now. all changes are applied. please check.
Hi @Rutik7066,
Thanks for your work on the PR! I noticed a couple of things that need to be addressed before we can merge it.
First, the PR title and test files mention "request compression," but your code actually addresses "response compression." Please update the wording in the test files and PR to reflect "response compression" instead.
Also, the AllowContentEncoding middleware you added checks if a request with a specific encoding can be decoded, but you didn't include support for it. Since it currently doesn't do anything, please remove this middleware.
Lastly, I want to remind you that the bounty is intended to be a solo challenge, and the requirements are quite clear. The level of help you're seeking goes beyond what's expected for this challenge.
Once you've made these changes, we can proceed with merging the PR. Thanks for your understanding!