Android crashes if cancelling a non existing notification

[xmmk]

Maybe the AlarmManager.cancel call should be inside the if !null statement

cancel() called with a null PendingIntent cancel AlarmManager.java:890 deleteAlarm RNLocalNotificationsModule.java:118 createAlarm RNLocalNotificationsModule.java:63 updateNotification RNLocalNotificationsModule.java:50 invoke Method.java invoke JavaMethodWrapper.java:372 invoke JavaModuleWrapper.java:160 run NativeRunnable.java handleCallback Handler.java:751 dispatchMessage Handler.java:95 dispatchMessage MessageQueueThreadHandler.java:29 loop Looper.java:154 run MessageQueueThreadImpl.java:192 run Thread.java:761

[wumke]

Very good point, will update it in next version!

[Fr33maan]

https://github.com/wumke/react-native-local-notifications/pull/26

[Fr33maan]

@wumke can push a version 2.0.1 ? I would like to avoid forking your package just for a so small fix

[wumke]

PR merged, I'm very busy at the moment... you can specify the commit key and get it directly from github instead of forking...

[Fr33maan]

@wumke right ! sad we not have a publish script in package.json. Thanks for your reactivity

[Fr33maan]

can use this in package.json "react-native-local-notifications": "git://github.com/wumke/react-native-local-notifications.git#dc5efd2ccdc434dfbffe4ece90849d68902c7767"

[wumke]

I use my private repo's like this with npm: "myprivatepckgname": "git+https://user:password@domain/path/to/myprivatepckg.git#hashvalue" Works perfectly!