react-native-immediate-phone-call icon indicating copy to clipboard operation
react-native-immediate-phone-call copied to clipboard

Phone call from specified sim slot

Open kukadiajayesh opened this issue 5 years ago • 3 comments

-For dual sim phone -Updated compileSDKVersion to 25

kukadiajayesh avatar Jan 08 '19 09:01 kukadiajayesh

Nice feature to add, I did not use 2 sim phones yet so would never ran into this need myself.

I gave it a quick look and will not merge it as-is because the iOS part is not updated, and the default value should not need to be set manually but be optional with a 'real default value' of 0 instead (or should we ask the user which one to use when no value is provided? or just provide a getter so users can manage their preferences themselves?). The readme should also specify that this only works for Android at the moment, or the iOS implementation should be included (I only have single sim apple devices)

If I find some time I will try to look how ios handles the 2 sim devices, but since I'm very busy at the moment I won't expect this to be the coming month... If anyone want to contribute, feel free and share your progress in this thread!

wumke avatar Jan 08 '19 09:01 wumke

@wumke Please could you check this ASAP, I'm working on an app to use call and I need this feature. So, could you please check this ASAP ?!

MustaMohamed avatar Jul 29 '19 14:07 MustaMohamed

I have no time to add and test this feature myself... but you can update this pull request with things I mentioned above.

wumke avatar Jul 29 '19 15:07 wumke