ssl-pinning-android icon indicating copy to clipboard operation
ssl-pinning-android copied to clipboard

Infinite stacking of cached same certificates with updates

Open vstudnicka-cen66454 opened this issue 2 years ago • 1 comments

CertStore.kt -> private fun processReceivedData(...) -> updateCachedData { cachedData -> ... }

This does check not work: if (newCertificates.indexOf(newCertificateInfo) != -1) { // skip entry that's already in the database continue }

Everytime it downloads trustlist it is checking if certificate is already in array. For every CertificateInfo it is creating new object and this code above is checking if same object is already in cachced array, but not comparing its data but only if it is same object. This results in in adding same certificate everytime it updates as it is always a newly created CerticateInfo object

image

vstudnicka-cen66454 avatar Jun 06 '22 13:06 vstudnicka-cen66454

@vstudnicka-cen66454 Thank you for reporting, adding @TomasKypta.

petrdvorak avatar Jun 06 '22 13:06 petrdvorak

@petrdvorak any update on this ticket?

tanvir-retailai avatar Jun 21 '23 03:06 tanvir-retailai