Joe Snell

Results 18 comments of Joe Snell

I don't have a .npmignore file in my repo, so is now-pipeline adding that somewhere? I see it in the file array.

Yes I will try to get a PR up within the hour. I've traced the requirement back to here: https://github.com/npm/fstream-npm/blob/master/fstream-npm.js#L300 It would seem that pkgd is just pulling that entire...

Yea that should work. I have an idea on how to add an optional list, just making sure I fully understand everything that’s going on.

Though this is hardly a fix, adding an empty .npmignore resolves the issue. I'm working on a fork to retool the whole file-checking section since there are a few different...

Apologies that I never got back to this. I've opened a PR with a simple change that should solve the issue.

@spences10 My changes were merged. Whenever the npm package is updated could you check and see if you are still experiencing that issue? I'm working on recreating the issue i...

Does this merge now resolve this issue? https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-cloudformation/pull/4

A quick-fix could be synchronizing the cdk-examples repo with the templates repo, but I don't really like that solution.