virtualized-table-for-antd change getBoundingClientRect from offsetwidth

change getBoundingClientRect from offsetwidth

Open NaokiFujikawa opened this issue 4 years ago • 6 comments

"offsetwidth" is round the value to an intege. So I want you to use "getBoundingClientRect".

https://developer.mozilla.org/ja/docs/Web/API/Element/getBoundingClientRect

The same thing happens with the issue below in the scroll view. https://github.com/ant-design/ant-design/issues/25300#issuecomment-652980264

Oct 12 '20 03:10 NaokiFujikawa

@NaokiFujikawa i will pay attention to this issue

Oct 12 '20 12:10 wubostc

@NaokiFujikawa i will pay attention to this issue

can you put some examples on https://codesandbox.io which can show the differences that you said.

Oct 12 '20 13:10 wubostc

Thank you for your interest. I made a sample for you. https://codesandbox.io/s/pull73-forked-oscod

This is caused by changing the display settings The differences in the display settings are shown below.

When the display setting is 100%, there is no problem. display100 100

But it occurs when you set it to 125%. The scroll bar will be active. display125 125

Oct 13 '20 03:10 NaokiFujikawa

this commit has a big problem... it will cause the height of each tr to be increased by 1

Oct 16 '20 11:10 wubostc

the main problem at present is that there is no way to set a floating-number for css...

Oct 16 '20 11:10 wubostc

Thank you for checking.

I see. I'm fine in my use, but I didn't think about PR.

Oct 16 '20 13:10 NaokiFujikawa