react-upload-file icon indicating copy to clipboard operation
react-upload-file copied to clipboard

Not use react-dom + input tag name

Open hasnat opened this issue 7 years ago • 5 comments

I was going to add react-dom to webpack external, but we don't need react-dom its only being used to findNode to set as input, which I have changed to ref as a method for same input.

This brings down dist min file from 230kb to 7kb (not gzipped)

hasnat avatar Jul 18 '17 18:07 hasnat

ping @wubocong

hasnat avatar Aug 28 '17 19:08 hasnat

Would love to see this merged, will use your fork for now. Cheers

stevenkissack avatar Oct 10 '17 04:10 stevenkissack

Yea, You can use https://www.npmjs.com/package/@hasnat/react-upload-file for now.

hasnat avatar Oct 10 '17 05:10 hasnat

Added another commit which adds optional prop inputName to help specify file input tag name

hasnat avatar Dec 22 '17 11:12 hasnat

@wubocong

linonetwo avatar Jan 16 '18 05:01 linonetwo