gradle-aem-plugin icon indicating copy to clipboard operation
gradle-aem-plugin copied to clipboard

Avoid saving user-specific data in instance scripts

Open pun-ky opened this issue 4 years ago • 4 comments

Task instanceUp is saving e.g JAVA_EXECUTABLE absolute path in control/\*.\[bat|sh] scripts and  it makes instances not usable directly when extracted externally (outside of GAP usage). 

Consider passing user-specific data to instance scripts using arguments or env vars instead of writing them down to files that could be later a part of instance backups.

Thx @szymon-owczarzak for reporting it!

pun-ky avatar Jan 13 '21 07:01 pun-ky

Or a system variable for the username could be used in JAVA_EXECUTABLE: C:\Users\%Username%\.gradle\jdks\jdk8u275-b01\bin\java.exe

szymon-owczarzak avatar Jan 14 '21 07:01 szymon-owczarzak

How about backup made on Unix but reused on windows? 😁 Nope

pun-ky avatar Jan 14 '21 11:01 pun-ky

for *.sh we could use $HOME/.gradle/jdks... and for *.bat %userprofile%/.gradle/jdks..

szymon-owczarzak avatar Jan 14 '21 11:01 szymon-owczarzak

Distro of Java determined by Gradle could be different for each OS.

pun-ky avatar Feb 26 '21 18:02 pun-ky