bobcat icon indicating copy to clipboard operation
bobcat copied to clipboard

Handling AEM Core components

Open mkrzyzanowski opened this issue 5 years ago • 22 comments

Adobe maintains a set of core components: https://github.com/adobe/aem-core-wcm-components.

The scope of this task is to investigate if Bobcat can handle authoring using these components and add such capability wherever it is not possible.

Note: we're assuming the latest version of Core components

Environment:

Components:

Template components

Page authoring components

Container components

Form components

mkrzyzanowski avatar Aug 26 '19 11:08 mkrzyzanowski

I'll join, will take care of Title first

kaczymuczy avatar Sep 06 '19 16:09 kaczymuczy

Next on my list is List

kaczymuczy avatar Sep 08 '19 09:09 kaczymuczy

Text is already covered by ConfigureComponentTest - checking it on the list as "done"

kaczymuczy avatar Sep 18 '19 11:09 kaczymuczy

Next - Image

kaczymuczy avatar Sep 18 '19 11:09 kaczymuczy

Hi, I take care of Teaser component

jaskowskak avatar Oct 01 '19 14:10 jaskowskak

@kaczymuczy @jaskowskak @mkrzyzanowski Good Job!!

DeChrish avatar Oct 04 '19 22:10 DeChrish

I will take a look on Download component

EDIT: Regarding AEM properties Download component is deprecated since 6.5 version image

Danon9111 avatar Oct 05 '19 21:10 Danon9111

I'm joining too. I will take care of Button component.

barbasial avatar Oct 09 '19 07:10 barbasial

I'll put the Content Fragment now under my looking glass

kaczymuczy avatar Oct 09 '19 08:10 kaczymuczy

I will take a look on the Separator component

Danon9111 avatar Oct 11 '19 08:10 Danon9111

I'll take care of Carousel

jaskowskak avatar Oct 11 '19 10:10 jaskowskak

Separator is a core component and available in AEM 6.5. Unfortunately it is not available (by default) under We Retail content. It is available only under component demo pages (../content/core-components-examples/library).

We can make it available by modifying default configuration of 'content-page' template under We Retail branch. (This need to be confirmed, if is it possible to automate this action)

We can also prepare tests for Separator component, which will work under path

/content/core-components-examples/library

Or we can drop this component.

@mkrzyzanowski @Shaihuludus what do you think?

P.S. As I heard there is bigger number of components whit similar situation. Maybe it would be valuable to verify which components?

Danon9111 avatar Oct 11 '19 10:10 Danon9111

Tests for Teaser component: https://github.com/Cognifide/bobcat-aem-tests/pull/12

jaskowskak avatar Oct 14 '19 10:10 jaskowskak

Creating tests for Separator component will be dropped. Reasons behind it are:

  • Separator component does not have any configuration dialog
  • In default AEM solution, for Separator component Author can change only Style Variant
  • Bobcat does not support operations on Style Variants. New ticket for this is open https://github.com/Cognifide/bobcat/issues/392

I have also noticed that in Core Components 2.6.0 is added new component - Experience Fragment and in Core Components 2.7.0 Embed . Do we want add them to the list and create tests for them?

Danon9111 avatar Oct 14 '19 11:10 Danon9111

I will try Sharing component this time ;)

Danon9111 avatar Oct 14 '19 12:10 Danon9111

Sharing component need some special configuration of page properties. We can achieve this by "hard coding" this properties, but after that we don't have anything to automate. Other way is to create mechanism in Bobcat to set proper page properties. For this purpose I have create issue in main Bobcat repo - https://github.com/Cognifide/bobcat/issues/393

For now, there is no sense to create any tests for Sharing component.

Danon9111 avatar Oct 14 '19 14:10 Danon9111

I will work on breadcrumb right now

Danon9111 avatar Oct 15 '19 07:10 Danon9111

I will try Accordion

barbasial avatar Oct 15 '19 08:10 barbasial

I'm going for the Content Fragment List

kaczymuczy avatar Oct 22 '19 07:10 kaczymuczy

Working on Tabs now

kaczymuczy avatar Oct 22 '19 14:10 kaczymuczy

Going for Form Container

kaczymuczy avatar Oct 23 '19 15:10 kaczymuczy

Actually I'll take all Form Components should no one protest :)

kaczymuczy avatar Oct 23 '19 15:10 kaczymuczy