aet icon indicating copy to clipboard operation
aet copied to clipboard

Move to Github Actions

Open devzbysiu opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. In a process of modernizing CI/CD, we are going to move from Jenkins + Travis (for checks), to Github Actions.

Describe the solution you'd like What should be done in Github Actions:

  • [x] PR cannot be merged until checks pass, checks should run test and license validation via RAT
  • [x] after the merge, CI workflow should trigger a build and generate code coverage
  • release workflow should be implemented:
    • [x] updating AET changelog
    • [x] bumping version
    • [x] uploading artifacts to AET Release page
    • [x] creating PR with changelog changes

We should be able to trigger the workflow manually and have control over the version number we are going to release.

Describe alternatives you've considered N/A

Additional context N/A

devzbysiu avatar Feb 26 '21 07:02 devzbysiu

This is finished developer-wise. The next steps are:

  • take care of internal environment issue in relation to https://github.com/wttech/aet/issues/624
  • deploy the release and test it

devzbysiu avatar Feb 26 '21 09:02 devzbysiu

You can find the code coverage here.

You can see the details of the release process here (note: you won't see that unless you can login to our confluence space)

devzbysiu avatar Mar 01 '21 08:03 devzbysiu

@devzbysiu Automatic PR failed to trigger check.

pilarskie avatar Mar 05 '21 12:03 pilarskie

@pilarskie it's fixed now. The issue was related to the github bot creating a PR. Github actions have a safety net for infinite loop triggered by bots. Because of that, the PR which is created by the bot does not trigger the workflow. The workaround for that is to use an existing user to create a PR.

From the functional perspective, nothing changed. The release is created the same way. After it finishes, the PR should have triggered PR check.

devzbysiu avatar Mar 15 '21 10:03 devzbysiu

Tested and accepted.

pilarskie avatar Mar 16 '21 12:03 pilarskie