aet
aet copied to clipboard
Research a tool that will validate code quality at GitHub
Research a tool that will validate code quality on GitHub and apply it as a PoC on existing AET GitHub repo, then integrate it with current codebase and check it (no fixes are in scope of this task).
We may use SonarQube.com for that purpose. See pull request https://github.com/Cognifide/aet/pull/33
Done some investigation around usage of Sonarqube.com. As long as those improvements are upcoming;
- https://docs.travis-ci.com/user/sonarqube/#Upcoming-improvements
we could use some additional artificial user for internal pull request analysis. The account which would add comments about Sonarqube violations.
This user needs to have following permissions:
- https://docs.sonarqube.org/display/PLUG/GitHub+Plugin#GitHubPlugin-GitHub
It's already set up on AEM Rules plugin. Drop me a line in case of any questions. https://sonarqube.com/dashboard?id=com.cognifide.aemrules%3Aaemrules https://github.com/Cognifide/AEM-Rules-for-SonarQube
I have also prepared some config for checking feature branches waiting for merge. See: https://github.com/orrrg/test/blob/master/.travis.yml