aet icon indicating copy to clipboard operation
aet copied to clipboard

Research a tool that will validate code quality at GitHub

Open malaskowski opened this issue 9 years ago • 4 comments

Research a tool that will validate code quality on GitHub and apply it as a PoC on existing AET GitHub repo, then integrate it with current codebase and check it (no fixes are in scope of this task).

malaskowski avatar Oct 03 '16 09:10 malaskowski

We may use SonarQube.com for that purpose. See pull request https://github.com/Cognifide/aet/pull/33

wiiitek avatar Nov 21 '16 23:11 wiiitek

Done some investigation around usage of Sonarqube.com. As long as those improvements are upcoming;

  • https://docs.travis-ci.com/user/sonarqube/#Upcoming-improvements

we could use some additional artificial user for internal pull request analysis. The account which would add comments about Sonarqube violations.

This user needs to have following permissions:

  • https://docs.sonarqube.org/display/PLUG/GitHub+Plugin#GitHubPlugin-GitHub

wiiitek avatar Mar 21 '17 01:03 wiiitek

It's already set up on AEM Rules plugin. Drop me a line in case of any questions. https://sonarqube.com/dashboard?id=com.cognifide.aemrules%3Aaemrules https://github.com/Cognifide/AEM-Rules-for-SonarQube

chutch avatar Mar 21 '17 07:03 chutch

I have also prepared some config for checking feature branches waiting for merge. See: https://github.com/orrrg/test/blob/master/.travis.yml

wiiitek avatar May 09 '17 08:05 wiiitek