BeautyGAN_pytorch icon indicating copy to clipboard operation
BeautyGAN_pytorch copied to clipboard

makeup loss

Open SeeU1119 opened this issue 5 years ago • 7 comments

Hi, thanks for your implement work, but i doubt wheater the implement of makeup loss is correct, the paper says that we should calculate the histogram matching between src image and ref image firstly, then calculate the l2 norm between fake image which generated by generator and matched image, i find that you just calculate makeuo loss between the generated image and reference image which dont normlization the value to [-1, 1], and use L1 norm, could you help me? thanks!

SeeU1119 avatar Oct 18 '19 04:10 SeeU1119

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

wtjiang98 avatar Oct 22 '19 02:10 wtjiang98

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

CodingMice avatar Oct 22 '19 09:10 CodingMice

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

wtjiang98 avatar Oct 22 '19 10:10 wtjiang98

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

CodingMice avatar Oct 23 '19 02:10 CodingMice

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

lambda_his = 1 lambda_his_lip = 1 lambda_skin = 0.1 lambda_eye = 1 The default settings at 'train.py'

wtjiang98 avatar Oct 23 '19 03:10 wtjiang98

That may be a little difference with the statement in paper. You can also try to implement yourself and make a PR.

Hi, I have implemented makeuploss myself before, almost the same as your implement work. But it seems that the color of HM result is sometimes far away from the reference image.

Yes, your observation is normal. Because HM is only a coarse gudiance, which need adv training to refine. If the results are perfect, there is no need to propose BeautyGAN.

Okay. Could you please tell me how to balance the weights of all losses? I have tried many times before...

lambda_his = 1 lambda_his_lip = 1 lambda_skin = 0.1 lambda_eye = 1 The default settings at 'train.py'

Thank you. It is the same as the description in paper. And I wonder how you get that weights, and the weights of GANLoss.

CodingMice avatar Oct 25 '19 01:10 CodingMice

Does it work? How do I import the data set? I have a problem importing it

Hao-Ning avatar Jan 07 '20 10:01 Hao-Ning