OSM-Surveyor icon indicating copy to clipboard operation
OSM-Surveyor copied to clipboard

Show more than 10 search results

Open bryceco opened this issue 4 years ago • 2 comments

You probably want to add “&limit=50” to the Nominatim search URL:

https://github.com/wtimme/OSM-Surveyor/blob/dcb8933065e558e8a73ca6e48fe3d7bd8c6742f4/OSMSurveyorFramework/Nominatim/NominatimResultProvider.swift#L27

bryceco avatar Aug 28 '20 02:08 bryceco

Thanks for the feedback, @bryceco!

This looks quite easily doable, thanks for providing the link to the line! I don't have that much experience with that particular API. Are there search strings that you put in where the default limit of the results is too small? For me personally, the first couple of search results usually do.

The thing that bothers me a bit with the search is that substrings are not found as expected. For example, when I search for "Trafalge" in order to find "Trafalgar Square", Nominatim returns zero results. But since the same is true for openstreetmap.org, I don't think that is an issue with the app.

wtimme avatar Aug 28 '20 07:08 wtimme

Probably 80-90% of the time the first 10 results are sufficient. But every once in a while it doesn't find a feature I know is mapped and only after double-checking I realize it didn't appear because of the 10 item (default) cutoff.

I don't think there's a way to do a substring match like you want.

bryceco avatar Aug 28 '20 07:08 bryceco