OSM-Completionist icon indicating copy to clipboard operation
OSM-Completionist copied to clipboard

Move rendering of Notes to dedicated layer

Open wtimme opened this issue 5 years ago • 1 comments
trafficstars

User Story

As a developer, I want the fetching and rendering of the notes to be moved out of MapView, so that MapView has less responsibilities

Acceptance Criterias

  • The code for fetching the notes is moved to dedicated file(s)

Unhappy Cases

If these changes were not merged back to (bryceco/GoMap), the chances of merge conflicts increase.

@bryceco, is there anything I can do to increaes the chance that this will get merged also to your main repository?

Additional context

This is some preparation for #28. When we use protocols, we might be able to display quests the same way.

wtimme avatar Feb 07 '20 19:02 wtimme

I’m fine with a change like this as long as it doesn’t change the existing behavior. I suspect it’s going to cause issues similar to #62, but if that is addressed I’ll accept the pull.

bryceco avatar Apr 14 '20 22:04 bryceco