wtf icon indicating copy to clipboard operation
wtf copied to clipboard

PiHole module does not use auth token to get status

Open Muscaw opened this issue 1 year ago • 3 comments

Hey, first of all, I'd like to say I'm super grateful for this repo to exist. I've been setting it up this morning and it's just awesome.

While setting up the pihole module, I noticed that the status does not show up. Basically, there is an unmarshal error when decoding the json.

Upon more investigation, I noticed that the requests is returning a HTTP 200, but the body is an empty json array.

The other requests (top clients and top domains) made by wtfutil to PiHole are working as expected and return expected values.

I'm happy to provide a PR with the fix.

What's broken?

The pihole module does not send the auth token when fetching the pihole server status. This results in a HTTP 200 response with empty array body. The pihole module tries to unmarshal it, but is ultimately unsuccessful

Muscaw avatar Oct 04 '23 13:10 Muscaw

Cool

nebbson avatar Nov 06 '23 07:11 nebbson

Apologies for the delay in responding, and thanks for the PR! I'll take a look and hopefully get it in.

senorprogrammer avatar Nov 16 '23 19:11 senorprogrammer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 15 '24 01:05 stale[bot]