fiasco icon indicating copy to clipboard operation
fiasco copied to clipboard

Subclassing the Particle class from PlasmaPy

Open wtbarnes opened this issue 6 years ago • 3 comments

Question: Should the Ion class subclass the Particle class from PlasmaPy?

The atomic subpackage in PlasmaPy provides an object for representing particles via the Particle class. Particle provides a convenient API to lots of metadata, e.g. mass, atomic number, symbol, etc. This would mean fiasco wouldn't have to re-implement all of this functionality.

fiasco already relies on PlasmaPy for getting the atomic number, symbol, and name.

Would there be any major conflicts with the existing Ion class and Particle? What would be the major benefits? Is the Particle API stable enough to rely that heavily on it?

wtbarnes avatar Dec 18 '18 07:12 wtbarnes