ImPlot.jl icon indicating copy to clipboard operation
ImPlot.jl copied to clipboard

Wrapper fixes

Open sairus7 opened this issue 1 year ago • 1 comments

Motivation for this change is to make wrapper functions closer to original implot API, so user would not be surprised too much by another wrapper layer. So I leave only convenience API changes: default argument values changed to kwargs, default array lengths, type promotions, struct fields conversion.

Widgets with label_id has it as first argument, consistent with other imgui widgets.

TODO: Make attention to possible method extension ambiguities.

sairus7 avatar Sep 10 '24 23:09 sairus7

Great, I think this a good idea :) I'm also planning to bump the compat bounds so this'll work with the latest CImGui, then we can add some simple tests with the demo (but that can come later).

JamesWrigley avatar Sep 11 '24 05:09 JamesWrigley

Shall we merge this?

JamesWrigley avatar Oct 16 '24 18:10 JamesWrigley

Yes I think, at least test examples work with these changes.

sairus7 avatar Oct 16 '24 19:10 sairus7

Sweet sweet, I'll merge this then. The next thing we should do is regenerate the bindings with the latest CImGuiPack_jll and get it compatible with CImGui again.

JamesWrigley avatar Oct 16 '24 19:10 JamesWrigley