ImPlot.jl icon indicating copy to clipboard operation
ImPlot.jl copied to clipboard

Fix PlotBars() and PlotBarsH() wrappers

Open JamesWrigley opened this issue 1 year ago • 4 comments

Fixes #31. The wrappers for PlotErrorBars() and PlotErrorBarsH() are probably still broken though, will need to fix that later.

JamesWrigley avatar Mar 29 '24 11:03 JamesWrigley

(bump)

JamesWrigley avatar May 24 '24 23:05 JamesWrigley

(bump)

JamesWrigley avatar Jun 03 '24 17:06 JamesWrigley

(bump)

JamesWrigley avatar Jul 05 '24 21:07 JamesWrigley

(bump)

JamesWrigley avatar Jul 27 '24 12:07 JamesWrigley

(bump)

JamesWrigley avatar Aug 13 '24 21:08 JamesWrigley

@sairus7, do you have merge privs? If so could I nerd-snipe you into reviewing and merging this? :sweat_smile:

JamesWrigley avatar Sep 04 '24 21:09 JamesWrigley

Looks like there is conflicting wrapper keyword arguments with previous version. So this is a break change, right?

And also, do we really want to add another wrapper layer of different function signatures, just to make it shorter by one single flag ImPlotBarsFlags_Horizontal / ImPlotBarsFlags_None?

sairus7 avatar Sep 09 '24 14:09 sairus7

Yes, this would be a breaking change.

And also, do we really want to add another wrapper layer of different function signatures, just to make it shorter by one single flag ImPlotBarsFlags_Horizontal / ImPlotBarsFlags_None?

Well, I didn't add any wrappers here :) If you feel it's simpler to remove PlotBarsH() then I think that's also fine.

JamesWrigley avatar Sep 09 '24 15:09 JamesWrigley

I plan to change signatures closer to original implot functions (for example, all functions should have string ID as first argument), but let's leave it for another PR (see #34), as with PlotErrorBarsH(). For now its working and looks good. Merging.

sairus7 avatar Sep 10 '24 22:09 sairus7