product-microgateway icon indicating copy to clipboard operation
product-microgateway copied to clipboard

Published 20 hours ago • verified publisher icon wso2

Eliminate duplicate cluster creation when production and sandbox endpoints are the same

Open NomadXD opened this issue 2 years ago • 3 comments

Purpose

Eliminate duplicate cluster creation when production and sandbox endpoints are the same

Issues

Fixes https://github.com/wso2/product-microgateway/issues/3002

Automation tests

  • Unit tests added: Yes
  • Integration tests added: No

Tested environments

OS: macOS Monterey 12.4 Env (Docker/K8s): Docker 20.10.16 on Rancher Desktop 1.4.1

Maintainers: Check before merge

  • [x] Assigned 'Type' label
  • [x] Assigned the project
  • [x] Validated respective github issues
  • [x] Assigned milestone to the github issue(s)

NomadXD avatar Jul 07 '22 08:07 NomadXD

I guess it would be better to add an integration test too. An openapi with both production-endpoints and sandbox endpoints are the same. We do a call based on production token and sandbox token both. Covering the success path is enough.

VirajSalaka avatar Jul 18 '22 06:07 VirajSalaka

Shall we update this PR?

pubudu538 avatar Aug 10 '22 10:08 pubudu538

@pubudu538 Sure, I'll update this with the proposed changes.

NomadXD avatar Aug 12 '22 04:08 NomadXD