product-is
product-is copied to clipboard
Re-branding WSO2 Identity Server UIs guide contains incorrect code samples
Is your suggestion related to a missing or misleading document? Please describe.
- In the document [1], sample code given in step 1 to copy in to header.jsp file contains invalid characters (LATIN SMALL LETTER A WITH CIRCUMFLEX character) instead of quote symbols.
- Provided code
<%@include file=”../includes/localize.jsp” %>
<%@include file=”../includes/init-url.jsp” %>
- In the document [1], sample code snippet given in step 2 does not match with the imports already available product-footer.jsp file copied from includes folder.
- Available import in product-footer.jsp is as follows
<%@ page import="org.wso2.carbon.identity.application.authentication.endpoint.util.AuthenticationEndpointUtil" %>
But in the code provided in document referring to IdentityManagementEndpointUtil.i18n(recoveryResourceBundle, ...)
instead of AuthenticationEndpointUtil.i18n(resourceBundle, ...)
- Given sample code
<footer class="footer">
<div class="container-fluid">
<p>XYZ Company | ©
<script>document.write(new Date().getFullYear());</script>
<a href="<%=IdentityManagementEndpointUtil.i18n(recoveryResourceBundle, "business.homepage")%>"
target="_blank">
<i class="icon fw fw-wso2"></i>
<%=IdentityManagementEndpointUtil.i18n(recoveryResourceBundle, "Inc")%>
</a>
. <%=IdentityManagementEndpointUtil.i18n(recoveryResourceBundle, "All.rights.reserved")%>
</p>
</div>
</footer>
Describe the improvement
- Change the code with quote symbols
<%@include file="../includes/localize.jsp" %>
<%@include file="../includes/init-url.jsp" %>
- Provide sample code with
AuthenticationEndpointUtil.i18n(resourceBundle, ...)
<footer class="footer">
<div class="container-fluid">
<script>document.write(new Date().getFullYear());</script>
<a href="<%=AuthenticationEndpointUtil.i18n(resourceBundle, "business.homepage")%>"
target="_blank">
<i class="icon fw fw-wso2"></i>
<%=AuthenticationEndpointUtil.i18n(resourceBundle, "Inc")%>
</a>
. <%=AuthenticationEndpointUtil.i18n(resourceBundle, "All.rights.reserved")%>
</p>
</div>
</footer>
[1] - https://is.docs.wso2.com/en/5.10.0/develop/customizing-identity-server-uis/#step-4-edit-the-existing-header-and-footer-content
Should be fixed for IS 5.11 and 6.0.0