product-apim icon indicating copy to clipboard operation
product-apim copied to clipboard

[Choreo-Connect] Support header policies for response flow. Update method rewrite.

Open suksw opened this issue 2 years ago • 2 comments

Purpose

Update the following in Policies for Choreo Connect

  • Support policies addHeader, removeHeader for response flow.
  • Update method rewrite policy

Related PRs

https://github.com/wso2/apim-apps/pull/295 https://github.com/wso2/product-microgateway/pull/2983

Related Issues

https://github.com/wso2/product-microgateway/issues/2756

suksw avatar Jul 08 '22 11:07 suksw

Codecov Report

Base: 19.93% // Head: 16.57% // Decreases project coverage by -3.35% :warning:

Coverage data is based on head (04d0a93) compared to base (f779e18). Patch has no changes to coverable lines.

:exclamation: Current head 04d0a93 differs from pull request most recent head 95da0eb. Consider uploading reports for the commit 95da0eb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12926      +/-   ##
============================================
- Coverage     19.93%   16.57%   -3.36%     
+ Complexity      948      768     -180     
============================================
  Files           235      235              
  Lines         10450    10450              
  Branches       1078     1078              
============================================
- Hits           2083     1732     -351     
- Misses         8342     8685     +343     
- Partials         25       33       +8     
Flag Coverage Δ
integration_tests 16.57% <ø> (-3.36%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...clients/publisher/api/v1/OperationPoliciesApi.java 28.57% <0.00%> (-57.15%) :arrow_down:
...gration/clients/store/api/v1/dto/ScopeInfoDTO.java 0.00% <0.00%> (-54.35%) :arrow_down:
...clients/admin/api/dto/ExportThrottlePolicyDTO.java 0.00% <0.00%> (-54.35%) :arrow_down:
...ents/publisher/api/v1/EndpointCertificatesApi.java 25.00% <0.00%> (-50.00%) :arrow_down:
...on/clients/admin/api/dto/BlockingConditionDTO.java 0.00% <0.00%> (-49.19%) :arrow_down:
...ntegration/clients/publisher/api/v1/ScopesApi.java 22.22% <0.00%> (-44.45%) :arrow_down:
...s/publisher/api/v1/dto/OperationPolicyDataDTO.java 0.00% <0.00%> (-44.12%) :arrow_down:
...blisher/api/v1/dto/SubscriptionPolicyAllOfDTO.java 0.00% <0.00%> (-42.96%) :arrow_down:
...er/api/v1/dto/OperationPolicySpecAttributeDTO.java 0.00% <0.00%> (-42.31%) :arrow_down:
...lients/admin/api/dto/ThrottlePolicyDetailsDTO.java 0.00% <0.00%> (-38.58%) :arrow_down:
... and 82 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 08 '22 14:07 codecov[bot]

This PR is currently onHold. Keeping this PR on hold until the policy version changes mentioned by @1akshitha are made to both carbon-apimgt and apim-apps.

suksw avatar Sep 12 '22 11:09 suksw