kubernetes-apim icon indicating copy to clipboard operation
kubernetes-apim copied to clipboard

Add missing TLS secretName

Open Nickmman opened this issue 1 year ago • 1 comments

Purpose

Resolves the issue where TLS spec is broken, it is missing the required secretName.

Goals

Ingress objects get created properly.

Approach

Adding secretName, prefixed with tls-, completed via the hostname being used in each Ingress objects. Also, adjusted indentation to follow Kubernetes documentation.

User stories

Summary of user stories addressed by this change>

Release note

Add missing TLS secretName to Ingress.

Documentation

N/A - Value is automatically calculated.

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

  • Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? Yes
  • Ran FindSecurityBugs plugin and verified report? No
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? Yes

Samples

Currently deploying via ArgoCD, Ingresses currently fail to be created, due to Skipped a TLS block: spec.tls[0].secretName: Required value

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Nickmman avatar Jun 29 '23 18:06 Nickmman