carbon-device-mgt-plugins icon indicating copy to clipboard operation
carbon-device-mgt-plugins copied to clipboard

[SECURITY] Use HTTPS to resolve dependencies in Maven Build

Open JLLeitschuh opened this issue 6 years ago • 31 comments

mitm_build


This is a security fix for a vulnerability in your Apache Maven pom.xml file(s).

The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS. This leaves your build vulnerable to allowing a Man in the Middle (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system.

This vulnerability has a CVSS v3.0 Base Score of 8.1/10.

POC code has existed since 2014 to maliciously compromise a JAR file in-flight. MITM attacks against HTTP are increasingly common, for example Comcast is known to have done it to their own users.

This contribution is a part of a submission to the GitHub Security Lab Bug Bounty program.

Detecting this and Future Vulnerabilities

This vulnerability was automatically detected by LGTM.com using this CodeQL Query.

As of September 2019 LGTM.com and Semmle are officially a part of GitHub.

You can automatically detect future vulnerabilities like this by enabling the free (for open-source) LGTM App.

I'm not an employee of GitHub nor of Semmle, I'm simply a user of LGTM.com and an open-source security researcher.

Source

Yes, this contribution was automatically generated, however, the code to generate this PR was lovingly hand crafted to bring this security fix to your repository.

The source code that generated and submitted this PR can be found here: JLLeitschuh/bulk-security-pr-generator

Opting-Out

If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called .github/GH-ROBOTS.txt to your repository with the line:

User-agent: JLLeitschuh/bulk-security-pr-generator
Disallow: *

This bot will respect the ROBOTS.txt format for future contributions.

Alternatively, if this project is no longer actively maintained, consider archiving the repository.

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

- Git Commit Signoff documentation

If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.

Tracking

All PR's generated as part of this fix are tracked here: https://github.com/JLLeitschuh/bulk-security-pr-generator/issues/2

JLLeitschuh avatar Feb 11 '20 16:02 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Feb 21 '20 17:02 stale[bot]

Not for lack of trying

JLLeitschuh avatar Feb 21 '20 17:02 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Mar 03 '20 03:03 stale[bot]

Hi! This should still be merged.

JLLeitschuh avatar Mar 03 '20 03:03 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Mar 13 '20 07:03 stale[bot]

Not stale. Still here.

JLLeitschuh avatar Mar 13 '20 13:03 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Mar 23 '20 13:03 stale[bot]

👋 Hi. This should be merged.

JLLeitschuh avatar Mar 23 '20 14:03 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Apr 02 '20 14:04 stale[bot]

Boo! 👻

JLLeitschuh avatar Apr 02 '20 15:04 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Apr 12 '20 16:04 stale[bot]

Shoo!

JLLeitschuh avatar Apr 13 '20 13:04 JLLeitschuh

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 17 '20 21:04 CLAassistant

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Apr 28 '20 04:04 stale[bot]

Not stale

JLLeitschuh avatar May 27 '20 11:05 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jun 06 '20 11:06 stale[bot]

Boo! 👻

JLLeitschuh avatar Jun 15 '20 19:06 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jun 26 '20 04:06 stale[bot]

@stale Shoo!

JLLeitschuh avatar Jun 29 '20 13:06 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jul 11 '20 01:07 stale[bot]

Nope

JLLeitschuh avatar Jul 13 '20 13:07 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jul 25 '20 04:07 stale[bot]

Go away @stale

JLLeitschuh avatar Aug 02 '20 03:08 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Aug 16 '20 07:08 stale[bot]

Good lord, this is kinda getting annoying.

JLLeitschuh avatar Aug 17 '20 17:08 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Aug 29 '20 08:08 stale[bot]

Shoo!

JLLeitschuh avatar Aug 31 '20 21:08 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Sep 11 '20 03:09 stale[bot]

Go away!

JLLeitschuh avatar Sep 11 '20 14:09 JLLeitschuh

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jan 08 '22 23:01 stale[bot]