Tapir-LLVM icon indicating copy to clipboard operation
Tapir-LLVM copied to clipboard

LoopSpawning reports that it did not transform anything if verifyFunction() fails.

Open VictorYing opened this issue 7 years ago • 0 comments

Is there a design reason that LoopSpawning, at several points, checks the return value of verifyFunction() and, if the verification fails, it merely returns false indicating it did not transform anything, despite the fact that, at those locations in the code, some transformations have indeed been attempted? Was there some point during development where letting bad transformed code continue through the compilation pipeline made sense? I have sometimes locally changed the verifyFunction() checks into asserts which was useful when I was debugging an issue,

VictorYing avatar Oct 22 '17 21:10 VictorYing