wslu icon indicating copy to clipboard operation
wslu copied to clipboard

fix: [#268] do not validate URL when skip flag is used

Open JaZo opened this issue 5 months ago • 0 comments

Description

I stumbled upon #268 and saw you added the -s, --skip-validation-check flag. I checked the fix, but if I interpret the code correctly, it still does validate the URL, but now it just ignores the result. This does not fix the issue with one-time URL's described in https://github.com/wslutilities/wslu/issues/268#issuecomment-1476208820. The name of the flag also suggests it completely skips the check instead of ignoring the result, so that's what I changed it into.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected) are no longer accepted

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist:

  • [x] I have read Code of Conduct and Contributing documentations.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

JaZo avatar Jan 11 '24 14:01 JaZo