Wilfredo Sánchez Vega
Wilfredo Sánchez Vega
In #359, @glyph [notes](https://github.com/twisted/klein/pull/359#discussion_r457891392): > The real problem here though appears to be that we are constructing a `KleinRequest` via adaptation - apparently for no good reason. Rather than lie...
Per @glyph: `_decorators.modified` can have a more precise signature. See https://github.com/twisted/klein/pull/311#discussion_r427028139.
Per @glyph: We should probably define a `Protocol` that defines `__klein_bound__` (and `__call__` probably) so we can document it somewhere. See https://github.com/twisted/klein/pull/311#discussion_r427027246
Use [mypy-zope](https://github.com/Shoobx/mypy-zope) to add zope.interface support to type checking
Make new request/response API public. That would add to the package (`__init__.py`): * From `_imessage.py`: * `FountAlreadyAccessedError` * `IHTTPHeaders` * `IMutableHTTPHeaders` * `IHTTPMessage` * `IHTTPRequest` * `IHTTPResponse` * From `_headers.py`:...
The `route` decorator should accept `URL` objects as well as strings.
In https://github.com/twisted/klein/pull/139#pullrequestreview-15010666, glyph noted that it may be preferable to reuse code from `KleinResource`, possible the entire class when handling errors so that we have full consistency in how return...
When we write this is documentation: ``` app = Klein() ``` This suggests that an instance of `Klein` is an "application", which is confusing because we sometimes also write something...
Sequences of tuples in `treq.testing` are a terrible idea. Some classes with names attributes would be more appropriate. Here's an attempt at that: ```python # # Helpers for mocking treq...
I have some code following the example in the docs for `treq.testing.RequestSequence` and I find that if the response tuple includes any headers, it causes an exception which shows none...