wrye-bash icon indicating copy to clipboard operation
wrye-bash copied to clipboard

Load Order Handling Improvements, Part 2

Open Infernio opened this issue 4 years ago • 2 comments

Continuing from #309, which was mostly focused on 306/307.

308:

  • [x] Update.esm should not be written into plugins.txt for Skyrim LE and newer games (including Enderal). The game hardcodes it to load directly after the game master. Done in 1b412e16398edbf20ef53ab78d5513c367087a72.

309+:

  • [ ] games.TimestampGame#_persist_load_order must be rewritten so it makes the least mtimes changes possible - so on creating a new mod for instance and placing it after selected ones assign a mod time +1 sec instead of +60 secs - see _get_free_time_step elimination
  • expose saved load orders/active plugins lists and allow the user to edit them - a lot of thinking this needs (UI ?) -> new issue #361
  • revisit undo/redo -> clean invalid ? More traditional undo redo (remove redos on a new load order)-> will be investigated as part of issue #361
  • [ ] revisit master/children warnings - add a big fat one for ESM-flagged files that have a non-ESM-flagged file as master

Ut:

  • [ ] ccc file handling fixups - see https://github.com/orgs/wrye-bash/projects/2/views/1?pane=issue&itemId=65705657

Infernio avatar Feb 21 '21 13:02 Infernio

I think something regressed with actives cleaning. In Enderal SE, I get this on every boot with latest nightly:

_games_lo.py  184 _warn_lo: Fixed Load Order: added='None', removed='None', duplicates='lo_duplicates(Enderal - Forgotten Stories.esm), ', reordered from:
Skyrim.esm
Dawnguard.esm
HearthFires.esm
Dragonborn.esm
Update.esm
Enderal - Forgotten Stories.esm
Enderal - Forgotten Stories.esm
SkyUI_SE.esp
Bashed Patch, 0.esp
to:
Skyrim.esm
Dawnguard.esm
HearthFires.esm
Dragonborn.esm
Update.esm
Enderal - Forgotten Stories.esm
Enderal - Forgotten Stories.esm
SkyUI_SE.esp
Bashed Patch, 0.esp
_games_lo.py  211 _warn_active: Invalid Plugin txt corrected:
Removed duplicate entries from active list : Enderal - Forgotten Stories.esmReordered active plugins with fixed order from:
Skyrim.esm
Dawnguard.esm
HearthFires.esm
Dragonborn.esm
Update.esm
Enderal - Forgotten Stories.esm
to:
Skyrim.esm
Dawnguard.esm
HearthFires.esm
Dragonborn.esm
Update.esm
Enderal - Forgotten Stories.esm
Enderal - Forgotten Stories.esm

Infernio avatar Dec 29 '23 21:12 Infernio

Ah, figured it out. Enderal SE has a Skyrim.ccc with Enderal - Forgotten Stories.esm in it, which meant we got Enderal - Forgotten Stories.esm twice in must_be_active_if_present. Will push a fixup.

Infernio avatar Dec 29 '23 22:12 Infernio