pytimeparse icon indicating copy to clipboard operation
pytimeparse copied to clipboard

Months support doesn't seem to work

Open martinb3 opened this issue 9 years ago • 3 comments

Hello! Based on #7 and the PR #10 from @duramato, I expected to be able to use an expression like "1 month" using the current HEAD, but that doesn't seem to actually work:

$  mkvirtualenv foo
$ workon foo
$ pip install -e -e git://github.com/wroberts
$ pip install -e git://github.com/wroberts/pytimeparse.git@cc0550d3f4ec72d745ef2387603005ab52aa9538#egg=pytimeparse
Obtaining pytimeparse from git+git://github.com/wroberts/pytimeparse.git@cc0550d3f4ec72d745ef2387603005ab52aa9538#egg=pytimeparse
  Cloning git://github.com/wroberts/pytimeparse.git (to cc0550d3f4ec72d745ef2387603005ab52aa9538) to ./.virtualenvs/foo/src/pytimeparse
  Could not find a tag or branch 'cc0550d3f4ec72d745ef2387603005ab52aa9538', assuming commit.
Installing collected packages: pytimeparse
  Running setup.py develop for pytimeparse
Successfully installed pytimeparse
(foo) ➜  ~  python
Python 2.7.12 (default, Jun 29 2016, 14:05:02)
[GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pytimeparse.timeparse import timeparse
>>> timeparse("1 month")
>>> timeparse("30 days")
2592000
>>>

martinb3 avatar Jan 10 '17 04:01 martinb3

Have you uncommented the references to months in the code?

duramato avatar Jan 10 '17 07:01 duramato

@duramato -- no, apparently I didn't catch that. I wasn't expecting that. Maybe this should be in a branch so it's at least able to be pip install'd?

martinb3 avatar Jan 10 '17 11:01 martinb3

When I added it, did it commented per @wroberts "wish", since months/years are relative times to the calendar, more info https://github.com/wroberts/pytimeparse/issues/7#issuecomment-62305025. To make it a branch sounds like a good idea, what you think @wroberts . Or maybe include it in the main branch.

duramato avatar Jan 10 '17 11:01 duramato