WRF icon indicating copy to clipboard operation
WRF copied to clipboard

CMake Chem and Chem+KPP Build

Open islas opened this issue 1 year ago • 2 comments

TYPE: enhancement

KEYWORDS: cmake, chem, kpp

SOURCE: internal

DESCRIPTION OF CHANGES: Problem: Current CMake build does not build chem or chem+kpp configurations

Solution: Build kpp and associated tools, and cmake commands to facilitate simplified logic of the configure_wkc and compile_wkc scripts. As with all CMake builds, all auto-generated source code is placed in the out-of-source build directory.

Notable differences to make build :

  • Use of Bison instead of Yacc as it is more easily accessible for install and usage as well as backward compatible
  • Allow -j N parallel jobs to generate KPP sources up to a limit
  • Use KPP-generated source file original names (not renamed to module_kpp_*
  • Pass tuv_kpp a directory to locate where include file is to be generated, and allow control of file IO mode*
  • Allow integration decomp rewrite to specify file locations rather than hard-coded*
  • registry uses -DWRF_CHEM and -DWRF_KPP defines passed at command line instead of getenv() to match all other options*

*Affects make build in subtle ways but do not change user instructions

LIST OF MODIFIED FILES: M CMakeLists.txt M chem/CMakeLists.txt A chem/KPP/CMakeLists.txt M chem/KPP/compile_wkc A chem/KPP/kpp/kpp-2.1/CMakeLists.txt A chem/KPP/util/wkc/CMakeLists.txt M chem/KPP/util/wkc/gen_kpp.c M chem/KPP/util/wkc/protos_kpp.h M chem/KPP/util/wkc/tuv_kpp.c A chem/KPP/util/write_decomp/CMakeLists.txt M chem/KPP/util/write_decomp/Makefile M chem/KPP/util/write_decomp/integr_edit.c M chem/chem_driver.F M tools/CMakeLists.txt M tools/data.h M tools/registry.c

TESTS CONDUCTED:

  1. Reproduction of chem and chem+kpp regtests with cmake is possible now

RELEASE NOTE: CMake Chem and Chem+KPP Build

islas avatar Mar 11 '24 20:03 islas

The Jenkins test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

weiwangncar avatar Mar 12 '24 01:03 weiwangncar

Requires #2056, #2053, #2086, #2087, and #2088

islas avatar Aug 06 '24 03:08 islas