WRF
WRF copied to clipboard
wrf-model
DON'T APPROVE! added model stop for ghg_input with nonsupported radiation options
TYPE: bug fix
KEYWORDS: ghg_input, radiation, module_check_a_mundo
SOURCE: internal
DESCRIPTION OF CHANGES: Problem: If a user had ghg_input turned on, but wasn't using one of the supported radiation physics options (i.e., not CAM, RRTM, RRTMG, or RRTMG_fast), the model would give an "ERROR" message, but wouldn't stop, nor would it make any changes to the settings. As long as everything else was correct, it would continue and write out the SUCCESS message at the end of the log files.
Solution: Added a "count_fatal_error = count_fatal_error + 1" to the check for this in module_check_a_mundo.F.
LIST OF MODIFIED FILES: M share/module_check_a_mundo.F
TESTS CONDUCTED:
-
Now, if non-supported radiation options are used with ghg_input, the model stops with the following message: -- ERROR: ghg_input available only for these radiation schemes: CAM, RRTM, RRTMG, RRTMG_fast And the LW and SW schemes must be reasonably paired together: OK = CAM LW with CAM SW OK = RRTM, RRTMG LW or SW, RRTMG_fast LW or SW may be mixed -------------- FATAL CALLED --------------- FATAL CALLED FROM FILE: LINE: 2794 NOTE: 1 namelist settings are wrong. Please check and reset these options
-
Are the Jenkins tests all passing? Waiting for results.
RELEASE NOTE: A bug fix was added to ensure the model stops when using ghg_input and a non-supported radiation physics option (i.e., anything other than CAM, RRTM, RRTMG, or RRTMG_fast).
Is this one not passing due to some regtest namelists not being consistent with the GHG switch?
@dudhia I'm working on it. The tests that are failing are due to reg-test namelists that use NO radiation. ghg_input = 0 was added to all other necessary namelists, but not those set to 0. I'm adding that now, then will do another test with the updated reg-test.
This reg-test only passed because the change was commented out. Don't approve it!