WRF icon indicating copy to clipboard operation
WRF copied to clipboard

Published 20 hours ago • verified publisher icon wrf-model

WRF-urban BEP_BEM longwave calculation for solar panel

Open cenlinhe opened this issue 2 years ago • 2 comments

https://github.com/wrf-model/WRF/blob/6233639c599119e76fca17dba9ea211af53a0ba9/phys/module_sf_bep_bem.F#L5319 @andreazonato In this calculation of gfl, do you think there is a missing parenthesis (marked as bold below): gfl=(1.-albr_u) * rs * (1-pv_frac_roof) + emr_u * rld * ( (1-pv_frac_roof) ) + ( pv_frac_roof * emr_u * sigma * tpvlev(id,iz)**4 ) & Basically, separate these two terms: emr_u * rld * (1-pv_frac_roof) and pv_frac_roof * emr_u * sigma * tpvlev(id,iz)**4

cenlinhe avatar Jan 08 '23 17:01 cenlinhe

Yes, I know about this issue. You are right.

I was planning to submit a pull request after AMS about it Thanks

Andrea

andreazonato avatar Jan 09 '23 15:01 andreazonato

@andreazonato Great. I will wait for you to submit the pull request for this bug fix.

cenlinhe avatar Jan 09 '23 15:01 cenlinhe