WSM6 tlad

[expertyang]

WSM6 tlad

TYPE: new feature

KEYWORDS: WSM6, TL/AD, 4DVAR

SOURCE: Sen YANG, Deqin LI, Liqiang CHEN (Institute of Atmospheric Environment, China Meteorological Administration, Shenyang)

LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M Registry/registry.var M Registry/registry.wrfplus M main/depend.common M phys/Makefile M phys/module_microphysics_driver.F A phys/module_mp_wsm6s.F M var/da/da_transfer_model/da_transfer_wrftltoxa.inc M var/da/da_transfer_model/da_transfer_wrftltoxa_adj.inc M var/da/da_transfer_model/da_transfer_xatowrftl.inc M var/da/da_transfer_model/da_transfer_xatowrftl_adj.inc M wrftladj/Makefile M wrftladj/adBuffer.F M wrftladj/adStack.c A wrftladj/adStack.h M wrftladj/depend.wrftladj M wrftladj/module_microphysics_driver_ad.F M wrftladj/module_microphysics_driver_tl.F A wrftladj/module_mp_wsm6s_ad.F A wrftladj/module_mp_wsm6s_tl.F M wrftladj/solve_em_ad.F M wrftladj/solve_em_tl.F

TESTS CONDUCTED:

1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

[dudhia]

It appears that this adds a new scheme called wsm6s. Please say more about why this new scheme is needed and how it differs from WSM6, and add a description in the PR message.

[weiwangncar]

This passed regression tests:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           58
Number of Simulations  : 158           156        0
Number of Comparisons  : 95           92        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[liujake]

@dudhia I will take care of this PR and add/request more info in PR message.

[liujake]

@expertyang

M wrftladj/adBuffer.F
M wrftladj/adStack.c
A wrftladj/adStack.h

I have issues to compile these code with gfortran with quite some error message below:

gfortran -c -ffixed-form -fdefault-real-8 -O0 adBuffer.for
adBuffer.for:232:25:

  232 |          CALL PUSHNARRAY(ads1buf, 512, 1)
      |                         1
......
  273 |          CALL PUSHNARRAY(adbitbuf, 4, 1)
      |                         2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(1)/INTEGER(4)).
adBuffer.for:245:24:

  245 |          CALL POPNARRAY(ads1buf, 512, 1)
      |                        1
......
  286 |          CALL POPNARRAY(adbitbuf, 4, 1)
      |                        2
Error: Type mismatch between actual argument at (1) and actual argument at (2) (CHARACTER(1)/INTEGER(4)).

After I recovered the old code. It compiled successfully.

[liujake]

@expertyang How about rename 'WSM6S' to 'WSM6R' meaning 'Regularized WSM6'.

[dudhia]

The regressions tests seem to be running slowly. Not sure why.

[liujake]

I compiled Ok 'wrfplus' and 'wrfda-4dvar' on Cheyenne. wrfplus compilation took about 1-h with '-j 2' using gfortran+mpt. 4dvar compilation took about 10 min with '-j 4' using gofrtran+mpt. I am doing WRFDA regression tests now.

[weiwangncar]

The Jenkins tests have passed according to the email below (but not sure why this page is not updated - have contacted the relevant people and is waiting for an answer):

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           58
Number of Simulations  : 158           156        0
Number of Comparisons  : 95           92        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

[liujake]

WRFDA regression tests passed and wrfplus & 4dvar with new wsm6r scheme succeeded. Ready to merge.

[liujake]

@dudhia I'd like to merge this Today if you approve.