WPS icon indicating copy to clipboard operation
WPS copied to clipboard

add `nocolons` option to `namelist.wps.all_options`

Open andreas-h opened this issue 6 years ago • 7 comments

It would be nice if nocolons would be added to the namelist.wps.all_options file, in order to improve discoverability by the user.

If welcome, I'm happy to submit a PR.

andreas-h avatar Dec 04 '18 15:12 andreas-h

It may have been quite some time since the nocolons option was actually tested, but assuming it works, I think submitting a PR to include it in the namelist.wps.all_options file sounds good to me.

mgduda avatar Dec 04 '18 18:12 mgduda

I seem to remember that the real program may not work with the nocolons option activated, where the metgrid file has underscores instead of colons.

davegill avatar Dec 04 '18 18:12 davegill

nocolons works in WRF but not WPS. In our fork for CMake we had to make changes to the following files: metgrid/src/{read,write}_met_module.F, ungrib/src/{datint,output,rrpr,ungrib}.F. In those files we simply replaced the colons with underscores in all cases without looking at a namelist option as it seemed to be a bit hard to get hold of it in certain cases.

letmaik avatar Dec 04 '18 20:12 letmaik

I used the nocolons option this week without problems in both WPS and real.exe.

andreas-h avatar Dec 12 '18 21:12 andreas-h

@andreas-h I seriously doubt that WPS in your case did not include colons in filenames. See some of the places below which unconditionally use colons. Can you name some example filenames that you got? Maybe we talk about different things.

https://github.com/wrf-model/WPS/blob/99f3ef5c56012b2a8cc43d845f6c722bed67f9bc/metgrid/src/write_met_module.F#L33-L39

https://github.com/wrf-model/WPS/blob/99f3ef5c56012b2a8cc43d845f6c722bed67f9bc/ungrib/src/output.F#L133-L157

https://github.com/wrf-model/WPS/blob/99f3ef5c56012b2a8cc43d845f6c722bed67f9bc/ungrib/src/ungrib.F#L389-L391

letmaik avatar Dec 12 '18 22:12 letmaik

File names look like this:

met_em.d05.2015-08-27_12_00_00.nc

Ungrib output does indeed contain colons, but as that's never being read by wrf with pnetcdf I don't mind.

andreas-h avatar Dec 13 '18 00:12 andreas-h

Revisiting this request - I've found that the colons in the ungrib output is breaking my workflow when using singularity containers.

The following bind statement fails - singularity tries to bind a SFCFILE file instead:

--bind \
    /[local path]/SFCFILE:2020-01-04_12:/UWFwyQ/SFCFILE:2020-01-04_12:ro \

I do note that singularity v3.9 onwards might not be subject to this limitation (see https://github.com/sylabs/singularity/issues/118) - but I'm stuck with singularity 3.5.2 on our local HPC system, which definitely can't cope with this issue.

douglowe avatar Apr 06 '23 13:04 douglowe