Gar
The pre-release portion of this RFC is implemented in https://github.com/npm/cli/pull/7910 The "semver precedence" portion overlaps with [rfc 7](https://github.com/npm/rfcs/blob/main/accepted/0007-publish-without-tag.md), and since there is no way to publish with *no* dist-tag, this...
We will definitely want a regression test on this one.
@marshallku yes. The fact that tests didn't fail w/ this bug means the tests are lacking here. We need some test that would fail w/ the old code but succeed...
It may be as simple as an assertion in an existing test that wasn't looking at the affected attributes. I haven't dug in to be sure.
We don't need to hard code it, but the test should probably be doing the same thing that the code itself is doing, namely looking in the git config file...
superceded by #315
``` > Semver.inc('1.7.2-1', 'patch') '1.7.2' > Semver.inc('1.7.2-1', 'minor') '1.8.0' > Semver.diff("1.7.2", "1.8.1") 'minor' ```
The reason is because this is parsing a URL object ```javscript resolvedUrl = new URL(rawWithPrefix, `file://${path.resolve(where)}/`) ``` Normally pathname is URI encoded ``` > new URL('file:///test dir') URL { href:...
This would be an issue w/ ecmascript itself, since this error also exists in browsers. The issue here is that `%` is not encoded in the pathname, and since it...
Looks like this issue is handled in node via [fileURLToPath](https://nodejs.org/api/url.html#urlfileurltopathurl-options)